Help Center: add image upload for chats #96105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~59 bytes added 📈 [gzipped]) Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~628 bytes added 📈 [gzipped]) Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~1513 bytes added 📈 [gzipped]) React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
escapemanuele
changed the title
| import { useCallback, useRef, useState } from '@wordpress/element'; | ||
| import { __ } from '@wordpress/i18n'; | ||
| import { Icon, upload } from '@wordpress/icons'; |
There was a problem hiding this comment.
We can also use image instead of upload to reflect what's in the designs. But we may think to ask Lucas to go with a generic upload if needed
heavyweight
changed the title
matticbot
added
the
[Status] Needs Review
agrullon95
added
the
[Feature] Help Center
| @@ -99,3 +99,15 @@ export const calculateUnread = ( conversations: ZendeskConversation[] ) => { | |||
|
|
|||
| return { unreadConversations, unreadMessages }; | |||
| }; | |||
|
|
|||
| export const getClientId = ( conversations: ZendeskConversation[] ) => { | |||
There was a problem hiding this comment.
I think we could reduce the nested loop to make it faster/simpler. I have tested and works great.
export const getClientId = ( conversations: ZendeskConversation[] ): string =>
conversations
.flatMap( ( conversation ) => conversation.messages )
.find( ( message ) => message.source.type === 'web' && message.source.id )?.source.id || '';| @@ -87,6 +89,7 @@ export const OdieSendMessageButton = () => { | |||
| keyUpHandle={ onKeyUp } | |||
| /> | |||
| { shouldBeDisabled && <Spinner className="odie-send-message-input-spinner" /> } | |||
| <AttachmentButton /> | |||
There was a problem hiding this comment.
WDYT if we add the shouldUseHelpCenterExperience check here instead of inside the component?, this would avoid unnecessary mounts
{shouldUseHelpCenterExperience && <AttachmentButton /> }| @@ -19,6 +19,21 @@ $blueberry-color: #3858e9; | |||
| height: 40px; | |||
| max-height: 210px; | |||
| } | |||
|
|
|||
| .components-form-file-upload { | |||
There was a problem hiding this comment.
@heavyweight I have added this to add the border and correct size
renancarvalho
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
@heavyweight I loved the simplicity of this PR, you did an astonishing job!
Left minimal suggestions, it's up to you to address them.
github-actions
bot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds support for image file uploads in zendesk conversations.
Fixes https://github.com/Automattic/dotcom-forge/issues/9644
Proposed Changes
Let's add the possibility of sending an image in the chat!
Testing Instructions
/home?flags=help-center-experienceand open the Help Center.